On Monday morning we (Mozilla) detected a very large crash spike affecting #Firefox users on Linux, specifically on an older version of a Debian-based distribution. It turned out to be an interesting bug involving the #Linux kernel and #Google JavaScript code so let me tell you about it. A thread 🧵

  • ono@lemmy.ca
    link
    fedilink
    arrow-up
    58
    ·
    1 year ago

    Highlights:

    The crash started apparently out-of-the-blue, hitting thousands of Argentinian users on a Debian-based distro called Huayra, and specifically on version 5 which was based on Debian 10.

    Everybody seemed to crash while searching for images on Google.

    Google’s code was allocating 20000 variables in a single frame.

    • spider@vlemmy.net
      link
      fedilink
      arrow-up
      7
      ·
      edit-2
      1 year ago

      Everybody seemed to crash while searching for images on Google.

      I’m experiencing this with Q4OS 3 (Centaurus), which under the hood is Debian 10 (Buster) – and with the supposedly more stable Firefox ESR.

      (Now using DuckDuckGo as an image search workaround.)

  • Spectacle8011A
    link
    fedilink
    arrow-up
    35
    ·
    1 year ago

    It is interesting though that we find ourselves working around a bug we did not introduce triggered by code we do not control.

    I imagine a lot of a browser’s codebase looks like this. From what I understand, browsers expect webmasters to screw up their markup and make allowances for it.

    • hare_ware@pawb.social
      link
      fedilink
      arrow-up
      9
      ·
      1 year ago

      Wdym? Almost all programs are like this, anything that uses an external library has issues like this.

      • Spectacle8011A
        link
        fedilink
        arrow-up
        3
        ·
        1 year ago

        I imagine so, but I don’t know the specifics of other software. It’s a quote from the Mastodon thread.

    • monobot@lemmy.ml
      link
      fedilink
      arrow-up
      5
      arrow-down
      11
      ·
      1 year ago

      I love Firefox and understand that making modern web browser is monumentally complex, but browser should not crash what ever some website does.

      That said, my Fennec is having problem with googlw images.

      • Spectacle8011A
        link
        fedilink
        arrow-up
        14
        arrow-down
        1
        ·
        1 year ago

        but browser should not crash what ever some website does.

        Sometimes crashing would be better than trying to beat wonky code into shape: https://samy.pl/myspace/tech.html

        1. Sweet! Now we can do javascript with single quotes. However, myspace strips out the word “javascript” from ANYWHERE. To get around this, some browsers will actually interpret “java\nscript” as “javascript” (that’s java<NEWLINE>script). Example: <div id=“mycode” expr=“alert(‘hah!’)” style=“background:url(‘java script:eval(document.all.mycode.expr)’)”>

        But on principle I agree. I can’t say whether Google Images works or not on my Firefox browser, because I’m using Mojeek.

        • monobot@lemmy.ml
          link
          fedilink
          arrow-up
          3
          ·
          1 year ago

          True, sometimes it is unavoidable.

          But this looks like kernel issue, it is fixed in kernel 4.20.

      • Atemu@lemmy.ml
        link
        fedilink
        arrow-up
        2
        ·
        1 year ago

        my Fennec is having problem with googlw images

        Interesting, mine isn’t. My FP4 is running 4.19, so it shouldn’t have the fix.

        I use nightly though, so perhaps the fix is already in?

        • monobot@lemmy.ml
          link
          fedilink
          English
          arrow-up
          2
          ·
          1 year ago

          I just updated it and is working nicely againg, thanks for recommendation.

  • lionkoy5555@lemmy.world
    link
    fedilink
    arrow-up
    21
    ·
    1 year ago

    maybe update your link to point to the correct post. The link you have is a post on a kbin instance which doesn’t have the full details, so i need to click again

  • Atemu@lemmy.ml
    link
    fedilink
    English
    arrow-up
    11
    ·
    1 year ago

    Why did you link a kbin instance rather than just cross-posting?

  • Felix@feddit.de
    link
    fedilink
    arrow-up
    2
    ·
    1 year ago

    Good, I already thought that it would crash so often, because I’m using Firefox from a custom ArchLinux repository.