A collection of Bad Code Smells in a Catalog form for Developers & Researchers. Code Smell is a typical bad code implementation, and learning these concepts immiedietly makes you a better developer!
The items don’t seem concise and always clear. But seems like a good, inspiring resource for things to consider.
If it is expected that a method might fail, then it should fail, either by throwing an Exception or, if not - it should return a special case None/Null type object of the desired class (following the Null Object Pattern), not null itself.
I’ve never heard of evading null with a Null object. Seems like a bad idea to me. Maybe it could work in some language, but generally I would say prefer result typing. Introducing a result type wrapping or extending the result value type is complexity I would be very evasive to introduce if the language doesn’t already support result wrapper/state types.
I’ve never heard of evading null with a Null object.
This is quite standard, and in fact it’s even a safety feature. C++ introduced nullptr defined as an instance of std::nullptr_t explicitly with this in mind.
Languages that make use of references rather than pointers don’t have this Dualism. C# has nullable references and nullability analysis, and null as a keyword.
Languages that make use of references rather than pointers don’t have this Dualism.
It’s not about references vs pointers. You could easily have a language that allowed “null references” (edit: too much C++; of course many languages allow null references, e.g. Javascript) or one that properly separated null pointers out in the type system.
I agree with your point though, using a special Null value is usually worse than using Option or similar. And nullptr_t doesn’t help with this at all.
Depends on your perspective. It’s convenient to lean on type checking to avoid a whole class of bugs. You can see this either as avoiding NULL or use your type system to flag misuses.
Languages that make use of references rather than pointers don’t have this Dualism. C# has nullable references and nullability analysis, and null as a keyword.
C#'s null keyword matches the monadic approach I mentioned earlier. Nullable types work as a Maybe monad. It’s the same concept shoehorned differently due to the different paths taken by these languages.
as far as I know, C# don’t have proper ergonomic monadic bind as in F# (computation expression), Haskell (do expression), and Ocaml (let*), but I could be wrong.
The items don’t seem concise and always clear. But seems like a good, inspiring resource for things to consider.
I’ve never heard of evading null with a Null object. Seems like a bad idea to me. Maybe it could work in some language, but generally I would say prefer result typing. Introducing a result type wrapping or extending the result value type is complexity I would be very evasive to introduce if the language doesn’t already support result wrapper/state types.
deleted by creator
This is quite standard, and in fact it’s even a safety feature. C++ introduced nullptr defined as an instance of std::nullptr_t explicitly with this in mind.
https://en.cppreference.com/w/cpp/language/nullptr
This approach is also quite basic in monadic types.
With what in mind? Evading
NULL?Languages that make use of references rather than pointers don’t have this Dualism. C# has nullable references and nullability analysis, and
nullas a keyword.What does your reasoning mean in that context?
It’s not about references vs pointers. You could easily have a language that allowed “null references” (edit: too much C++; of course many languages allow null references, e.g. Javascript) or one that properly separated null pointers out in the type system.
I agree with your point though, using a special
Nullvalue is usually worse than usingOptionor similar. Andnullptr_tdoesn’t help with this at all.Depends on your perspective. It’s convenient to lean on type checking to avoid a whole class of bugs. You can see this either as avoiding NULL or use your type system to flag misuses.
C#'s
nullkeyword matches the monadic approach I mentioned earlier. Nullable types work as aMaybemonad. It’s the same concept shoehorned differently due to the different paths taken by these languages.as far as I know, C# don’t have proper ergonomic monadic bind as in F# (computation expression), Haskell (do expression), and Ocaml (let*), but I could be wrong.
Correct.
This might be educational: https://docs.oracle.com/javase/8/docs/api/java/util/Optional.html
There are issues that the
Optionalclass alleviates that are common enough to be documented: https://www.jetbrains.com/help/inspectopedia/ConditionalCanBeOptional.html (more detail is available at places like https://github.com/JetBrains/intellij-community/blob/a2d32ec64ed0fb37c7cc97856aa94cce95b17ee5/java/java-impl/src/inspectionDescriptions/ConditionalCanBeOptional.html (I believe this information used to be visible with the “inspectopedia” URLs but I don’t see that today))On the other hand, it seems there are some features / situations that require
nullto be present: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining https://www.jetbrains.com/help/inspectopedia/OptionalToIf.html